From a697039c66d267045f2ab104c614934f62001efc Mon Sep 17 00:00:00 2001 From: Michal Vesely Date: Mon, 25 Sep 2017 14:50:19 +0200 Subject: [PATCH 1/2] add settable nginx daemon group --- manifests/config.pp | 1 + manifests/init.pp | 1 + templates/conf.d/nginx.conf.erb | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/manifests/config.pp b/manifests/config.pp index 79baac591..9e9290786 100644 --- a/manifests/config.pp +++ b/manifests/config.pp @@ -23,6 +23,7 @@ $conf_dir = $::nginx::conf_dir $daemon = $::nginx::daemon $daemon_user = $::nginx::daemon_user + $daemon_group = $::nginx::daemon_group $global_owner = $::nginx::global_owner $global_group = $::nginx::global_group $global_mode = $::nginx::global_mode diff --git a/manifests/init.pp b/manifests/init.pp index c6256b763..2b5cb9456 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -32,6 +32,7 @@ $conf_dir = $::nginx::params::conf_dir, Optional[Enum['on', 'off']] $daemon = undef, $daemon_user = $::nginx::params::daemon_user, + $daemon_group = undef, $global_owner = $::nginx::params::global_owner, $global_group = $::nginx::params::global_group, $global_mode = $::nginx::params::global_mode, diff --git a/templates/conf.d/nginx.conf.erb b/templates/conf.d/nginx.conf.erb index 409b7aaed..a5c16977e 100644 --- a/templates/conf.d/nginx.conf.erb +++ b/templates/conf.d/nginx.conf.erb @@ -3,7 +3,7 @@ daemon <%= @daemon %>; <% end -%> <% if @super_user -%> -user <%= @daemon_user %>; +user <%= @daemon_user %><% if @daemon_group -%> <%= @daemon_group %><% end -%>; <% end -%> worker_processes <%= @worker_processes %>; <% if @worker_rlimit_nofile -%> From bd0d78907d51792525eed619215fe1e751835794 Mon Sep 17 00:00:00 2001 From: Michal Vesely Date: Tue, 24 Oct 2017 08:57:24 +0200 Subject: [PATCH 2/2] add tests for daemon_group variable --- spec/classes/nginx_spec.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/spec/classes/nginx_spec.rb b/spec/classes/nginx_spec.rb index 0e1efd707..28b40c57b 100644 --- a/spec/classes/nginx_spec.rb +++ b/spec/classes/nginx_spec.rb @@ -343,6 +343,12 @@ value: false, notmatch: %r{user} }, + { + title: 'should not set group', + attr: 'daemon_group', + value: :undef, + notmatch: %r{^user \S+ \S+;} + }, { title: 'should set user', attr: 'daemon_user', @@ -1074,6 +1080,12 @@ it { is_expected.to contain_file('/etc/nginx/nginx.conf').with_content %r{^user www-data;} } end + context 'when daemon_group = test-group' do + let(:params) { { daemon_group: 'test-group' } } + + it { is_expected.to contain_file('/etc/nginx/nginx.conf').with_content %r{^user .* test-group;} } + end + context 'when log_dir is non-default' do let(:params) { { log_dir: '/foo/bar' } }