Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream_cfg_append #717

Closed
frankvolkel opened this issue Nov 13, 2015 · 4 comments
Closed

upstream_cfg_append #717

frankvolkel opened this issue Nov 13, 2015 · 4 comments
Labels
enhancement New feature or request

Comments

@frankvolkel
Copy link

There's no option to append config for upstream, this is currently not possible:

upstream backend {
    server backend1.example.com;
    server backend2.example.com;

    sticky cookie srv_id expires=1h domain=.example.com path=/;
}

It'd be great if upstream_cfg_append is available

@dhoppe dhoppe added the enhancement New feature or request label Sep 17, 2016
@wyardley
Copy link
Collaborator

wyardley commented Oct 8, 2016

There is an $upstream_cfg_prepend option.... adding append should be pretty easy. I'm guessing the order is mostly a cosmetic thing?

Is anyone willing to submit a PR for this? Should be mostly copy / pasta.

@wyardley
Copy link
Collaborator

Ok, not sure if you still need this, but it's reasonable and didn't take too long to add.
#953

@wyardley
Copy link
Collaborator

@frankvolkel If this is still something you use / want, please test if possible. Assuming this gets merged, should make the next module release, but you can get a patch from the PR above if you want to test.

@wyardley
Copy link
Collaborator

wyardley commented Nov 7, 2016

This is now merged, going to close this ticket for now.

@wyardley wyardley closed this as completed Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants