Deprecation warning when adding worker_processes through hiera

[ege1]

Hi,

as soon as I set
nginx::worker_processes: 2

Through hiera, I get the deprecation warning:

Notice: [nginx] * DEPRECATION WARNING*: HI! I notice that you're declaring some attributes in Class[nginx]. It is highly recommended to set these values via Hiera going forward. This will become mandatory in the near future. Please check out https://github.com/jfryman/puppet-nginx/blob/master/docs/hiera.md for more information.

I just removed the check for worker_processes to get around this message (because otherwise foreman always reports changes on the host), so this is not an issue to me.

So just so you know.

Kind Regards,

Erik

[PierreR]

👍 Same issue for me see referenced issue :-(

[3flex]

@ege1 does the error go away when you set it like this?

nginx::config::worker_processes: 2

[PierreR]

@3flex I am pretty sure It does not work with nginx::config::worker_processes (see #536) It is silently ignored unless you add include nginx::config (and at that point it fails ...). But yes the deprecation warning disappears.

As nobody seems able to give a working alternative, I would remove the deprecation warning all together ... I have been living with this WARNING for months ... The WARNING is plain wrong anyway as it does not know if the params comes from hiera or not ...

[3flex]

@jfryman might need to come up with an alternate solution that is a bit more robust than what we have at the moment... I agree the warning is not ideal in this case, and I'm not sure how best to re architect things to both match @jfryman's goals for the module's structure and also make things more user friendly.

[ege1]

@3flex Thanks for that hint. Yes, that works just perfect for me. It is recognized and it stops the deprecation warning. And i do not have explicitly included the nginx::config

So for me this is solved that way.