downgrade concat dependency for wider support

[decibelhertz]

Per https://forge.puppetlabs.com/puppetlabs/concat , 1.04 is the presently supported version of concat for folks using the newest supported versions of Puppet. 1.0.4 does not have an ensure parameter, making -- as far as I can tell -- nginx::resource::upstream (and only nginx::resource::upstream) the only type in this module that couldn't use an older, better supported version of concat.

While I agree that its desirable to purge any lingering files created by nginx::resource::upstream, would it not be reasonable, in the name of supporting a wider user base, to make a conditional that sets a file resource to 'absent' when that type's ensure parameter is set to 'absent', and -- as happens now -- sets a concat resource accordingly otherwise? Happy to submit a pull request that does so; just want to make sure my notion isn't in conflict with some philosophy I'm not aware of, or some other land mine in downgrading the dependency.

[3flex]

The ensure parameter is used in concat::fragment in other resources too (such as nginx::resource::location and nginx::resource::vhost), so if you made this change you'd need to check everything in the resources directory. You could try downgrading puppetlabs-concat in your own branch then running tests to see what breaks.

I don't think see an issue with following supported versions of the puppetlabs modules so I'm not opposed a PR. It would then be reverted when a newer supported concat module's released.

[decibelhertz]

Yup. All sounds reasonable and matches my expectations for workflow, etc.

I guess I wasn't clear enough about concat. concat::fragment has supported the ensure parameter for a long time; init.pp does not. As far as I see, only nginx::resource::upstream therefore has the issue with v1.04. I'll know more once I run the spec tests, etc., but here is what I'm looking at:

$ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
$ grep -R -A5 'concat {'  manifests
manifests/resource/mailhost.pp:  concat { $config_file:
manifests/resource/mailhost.pp-    owner  => 'root',
manifests/resource/mailhost.pp-    group  => $root_group,
manifests/resource/mailhost.pp-    mode   => '0644',
manifests/resource/mailhost.pp-    notify => Class['nginx::service'],
manifests/resource/mailhost.pp-  }
--
manifests/resource/upstream.pp:  concat { "${nginx::config::conf_dir}/conf.d/${name}-upstream.conf":
manifests/resource/upstream.pp-    ensure => $ensure_real,
manifests/resource/upstream.pp-    notify => Class['nginx::service'],
manifests/resource/upstream.pp-  }
manifests/resource/upstream.pp-
manifests/resource/upstream.pp-  # Uses: $name, $upstream_cfg_prepend
--
manifests/resource/vhost.pp:  concat { $config_file:
manifests/resource/vhost.pp-    owner  => $owner,
manifests/resource/vhost.pp-    group  => $group,
manifests/resource/vhost.pp-    mode   => $mode,
manifests/resource/vhost.pp-    notify => Class['nginx::service'],
manifests/resource/vhost.pp-  }

[decibelhertz]

Submitted #437 . We can continue further discussion there. Cheers.