Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no proxy for plugins #306

Closed
wants to merge 1 commit into from

Conversation

ricfeatherstone
Copy link

When downloading plugins proxy is set for http and https but no proxy is not.

This causes issues when wanting to configure the Jenkins proxy details but host plugins internally.

@jhoblitt
Copy link
Member

This looks reasonable.

The unit tests for jenkins::plugin are really lacking. Would you be willing to add coverage for the two exec resources this change will effect?

I'd also suggest squashing your history to remove the merge commits.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@ricfeatherstone
Copy link
Author

OK, history squashed and existing tests updated.

@rtyler rtyler added the enhancement New feature or request label Oct 3, 2015
@jhoblitt
Copy link
Member

@ricfeatherstone I really do appreciate your work on this PR! Since it was opened, all of exec resources have been removed from from jenkins::plugin. Additionally, the archive::download resource respects $jenkins::proxy_host. Regretfully, I'm going to close this PR but please do open a new issue/PR if there are still difficulties with proxy support.

@jhoblitt jhoblitt closed this Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants