Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with apt module #281

Closed
wants to merge 1 commit into from

Conversation

skolekonov
Copy link

  • key_source parameter was removed, key parameter should be used instead.
  • include_src was also removed and set to false by default, there's no need to
    override it anymore.

- key_source parameter was removed, key parameter should be used instead.
- include_src was also removed and set to false by default, there's no need to
  override it anymore.
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jhoblitt
Copy link
Member

jhoblitt commented May 3, 2015

This will likely require updating the fixtures, metadata.json, and some spec tests.

@bleuchtang
Copy link
Contributor

I fix lints and tests issues here: https://github.com/bleuchtang/puppet-jenkins/tree/puppetjenkins_PR_281 .
@skolekonov can you rebase my branch please ?

@cypherfox
Copy link

@bleuchtang: I have deployed your changes, and they work fine. Could you please create new pull request?
I have tried #301, but it has it's own problems.

@bleuchtang
Copy link
Contributor

@cypherfox: done here: #321

@jhoblitt
Copy link
Member

#323 has been merged; this PR can be closed out. /cc @rtyler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants