Refactor acceptance tests to use beaker-rspec #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can handle that all with beaker now
Adds in modules and creates hiera file
Add in gems for main beaker-rspec depenancies
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Interesting work @petems! I'll try to make sure I review this over the weekend, post haste! |
|
Cool :) I'll probably add a line to the README.md about how to run it, but the tl;dr is: Setup vagrant and virtualbox, then: Whats really cool is that beaker has docker support, so you can run acceptance tests in CI pretty easily without having to wait for the VM's to spin up (example here: https://app.wercker.com/#buildstep/542851191dfdddeb6b023822). |
As we're checking idempotency, we need to catch changes
|
@petems you're on the hook for adding a README update in another pull request. if I don't see it soon I'll have to beat it out of you at FOSDEM :) |
rtyler
pushed a commit
that referenced
this pull request
Jan 29, 2015
Refactor acceptance tests to use beaker-rspec
|
@rtyler Haha, I'll see what I can do! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows much easier tuning of tests, but still has serverspec so we can port over the existing tests. Beaker also has AWS support, so it's easy to test there too! 👍