Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix puppet lint errors #167

Merged
merged 1 commit into from
Aug 25, 2014
Merged

Fix puppet lint errors #167

merged 1 commit into from
Aug 25, 2014

Conversation

carlossg
Copy link
Member

They make the build fail when using puppet-lint 1.0.0+

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

They make the build fail when using puppet-lint 1.0.0+
Don't upgrade lint to 1.0.0 as it is failing in Travis
@matthewbarr
Copy link
Contributor

other than white space, any actual changes beyond the gem file?

@carlossg
Copy link
Member Author

nope, you can see at https://github.com/jenkinsci/puppet-jenkins/pull/167/files?w=true

Puppet lint 1.0.0 and 1.0.1 are still broken in travis. The white space changes should have fix that (works locally), but it doesn't, still getting the errors:

manifests/cli.pp:5:autoloader_layout:ERROR:jenkins::cli not in autoload module layout

I have created a branch to try with 1.0.0+ https://travis-ci.org/maestrodev/puppet-jenkins/branches

@matthewbarr
Copy link
Contributor

Just making sure there was nothing but white space fixes, other than the
gem file. I'll merge it now.

Sent from my iPad

On Aug 25, 2014, at 4:28 AM, Carlos Sanchez notifications@github.com
wrote:

nope, you can see at
https://github.com/jenkinsci/puppet-jenkins/pull/167/files?w=true

Puppet lint 1.0.0 and 1.0.1 are still broken in travis. The white space
changes should have fix that (works locally), but it doesn't, still getting
the errors:

manifests/cli.pp:5:autoloader_layout:ERROR:jenkins::cli not in
autoload module layout

I have created a branch to try with 1.0.0+
https://travis-ci.org/maestrodev/puppet-jenkins/branches


Reply to this email directly or view it on GitHub
#167 (comment)
.

matthewbarr added a commit that referenced this pull request Aug 25, 2014
@matthewbarr matthewbarr merged commit 8027c39 into voxpupuli:master Aug 25, 2014
@carlossg
Copy link
Member Author

thanks, I'll rebase the other fixes to get travis builds passing again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants