Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change data type of all TLS cert and key params back to String #713

Closed
lbetz opened this issue Dec 14, 2022 · 2 comments
Closed

Change data type of all TLS cert and key params back to String #713

lbetz opened this issue Dec 14, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@lbetz
Copy link
Contributor

lbetz commented Dec 14, 2022

refs #623

@lbetz lbetz added the bug label Dec 14, 2022
@lbetz lbetz self-assigned this Dec 14, 2022
@zilchms
Copy link
Contributor

zilchms commented Dec 14, 2022

Instead of reverting to String, maybe adding an own data type that is based on the base64 pattern could be a good solution, if validation is wanted?
(not sure what the right regex pattern would be)

@lbetz
Copy link
Contributor Author

lbetz commented Dec 15, 2022

I thought about it, but with header and footer or without or both? Take the simple solution with strings for now.

@lbetz lbetz closed this as completed Dec 16, 2022
@lbetz lbetz added this to the v3.5.0 milestone Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants