Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated stdlib functions #275

Closed
bobapple opened this issue Apr 7, 2017 · 7 comments
Closed

Replace deprecated stdlib functions #275

bobapple opened this issue Apr 7, 2017 · 7 comments
Labels
enhancement
Milestone
v2.0.0

Comments

@bobapple
Copy link
Contributor

bobapple commented Apr 7, 2017

The following functions we use from the stdlib module are deprecated and need to be replaced with validate_legacy

  • is_array
  • is_bool
  • is_string
  • validate_array
  • validate_bool
  • validate_hash
  • validate_re
  • validate_string
@lbetz
Copy link
Contributor

lbetz commented Apr 7, 2017

In this case we have to update to stdlib 4.13.0 and above.

@bobapple
Copy link
Contributor Author

bobapple commented Apr 7, 2017

I wouldn't update the stdlib requirement to 4.13 immediately, many people still run on old versions. Let's keep this issue as reminder.

@lbetz lbetz added this to the v1.3.0 milestone May 15, 2017
@lbetz lbetz modified the milestones: v1.3.1, v1.3.0 Jun 26, 2017
@lbetz
Copy link
Contributor

lbetz commented Sep 6, 2017

https://forge.puppet.com/puppetlabs/stdlib
shows: Note: This function is compatible only with Puppet 4.4.0 (PE 2016.1) and later.

So we'll lose puppet 3 compatibility.

@lbetz lbetz removed this from the v1.3.1 milestone Sep 11, 2017
@lbetz lbetz added this to the v2.0.0 milestone Sep 23, 2017
@lbetz
Copy link
Contributor

lbetz commented Sep 23, 2017

refers to:

#350
#362

@ekohl
Copy link
Member

ekohl commented Feb 6, 2018

I'd be happy to write a patch. Is dropping Puppet 3 a problem?

@baurmatt
Copy link
Contributor

baurmatt commented Feb 6, 2018

It's (more or less) done with #350

@lbetz
Copy link
Contributor

lbetz commented Feb 7, 2018

We start with dropping it after acceptence tests are implemented.

@lbetz lbetz closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@ekohl @bobapple @baurmatt @lbetz