Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiera.yaml is word readable, but it can contain secret tokens #265

Closed
maxadamo opened this issue Jun 10, 2019 · 2 comments · Fixed by #276
Closed

hiera.yaml is word readable, but it can contain secret tokens #265

maxadamo opened this issue Jun 10, 2019 · 2 comments · Fixed by #276

Comments

@maxadamo
Copy link
Contributor

maxadamo commented Jun 10, 2019

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: ANY
  • Ruby: ANY
  • Distribution: ANY
  • Module version: 3.4.1

How to reproduce (e.g Puppet code you use)

puppet agent -t 🐱

What are you seeing

file permissions being set to 0644

What behaviour did you expect instead

let the user assign different permissions. I do have Redis token and Hashicorp Vault token set in hiera.yaml

Any additional information you'd like to impart

I can't make any PR until next week, but I guess that adding an option for file mode, and overwriting the default permission in the line 268 should be trivial.

@maxadamo maxadamo changed the title hiera.yaml is word readable, but it can contain tokens hiera.yaml is word readable, but it can contain secret tokens Jun 10, 2019
@maxadamo
Copy link
Contributor Author

Pull Request is here: #266

@maxadamo
Copy link
Contributor Author

resolved by #266

This was referenced Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant