Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: forge doc says 'masterservice', should be 'master_service' #126

Closed
rjhornsby opened this issue Mar 16, 2016 · 3 comments
Closed

Minor: forge doc says 'masterservice', should be 'master_service' #126

rjhornsby opened this issue Mar 16, 2016 · 3 comments

Comments

@rjhornsby
Copy link

At the bottom of the forge page[1] for the hiera module, it says the parameter name is 'masterservice' but should say 'master_service'.

It's minor, but confusing when Puppet throws an error when trying to use masterservice.

[1] https://forge.puppetlabs.com/hunner/hiera

@alexjfisher
Copy link
Member

@rjhornsby This was fixed in 2ca529e and will be included in the soon to be released version 2.1.0. See #123

@alexjfisher
Copy link
Member

Version 2.1.0 is now available under it's new 'puppet' (voxpupuli) namespace. https://forge.puppet.com/puppet/hiera

@vchepkov
Copy link
Contributor

vchepkov commented May 21, 2016

Have you decided to change tag format for the releases?
Previous versions didn't have prefix 'v'

i.e. 2.0.1 vs v2.1.0

This section of CHANGELOG.md is incorrect because of it:

[2.1.0]: https://github.com/hunner/puppet-hiera/compare/2.0.1...2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants