Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ICMP block inversion in zones #270

Closed
ananace opened this issue Mar 10, 2020 · 5 comments · Fixed by #330
Closed

Support ICMP block inversion in zones #270

ananace opened this issue Mar 10, 2020 · 5 comments · Fixed by #330
Labels
enhancement New feature or request

Comments

@ananace
Copy link
Member

ananace commented Mar 10, 2020

Since firewalld version 0.4.2 there's been support for inverting the ICMP block list in a zone, turning it from a blacklist into a whitelist instead.

I'd love to see a parameter to enable this feature in the firewalld_zone type.
An interim - naïve - solution is;

exec { 'Invert ICMP blocks in public':
  command => 'firewall-cmd --zone=public --add-icmp-block-inversion',
  unless  => 'firewall-cmd --zone=public --query-icmp-block-inversion',
  path    => [ '/bin', '/usr/bin', ],
}
@ananace ananace added the enhancement New feature or request label Mar 11, 2020
@ananace
Copy link
Member Author

ananace commented Mar 11, 2020

Noticed that there's a PR #200 that solves this issue, so this will be done once that one's merged.

@tuxmaster5000
Copy link

Are there any news about the PR for it?

@jcpunk
Copy link
Contributor

jcpunk commented Sep 18, 2023

Reverted in #351 due to lack of skill on my end.

@jcpunk
Copy link
Contributor

jcpunk commented Sep 27, 2023

Tests fixed.

@jcpunk jcpunk closed this as completed Sep 27, 2023
@tuxmaster5000
Copy link

Thanks for the work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants