Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline release process #45

Closed
3 tasks done
igalic opened this issue Dec 18, 2015 · 9 comments
Closed
3 tasks done

streamline release process #45

igalic opened this issue Dec 18, 2015 · 9 comments

Comments

@igalic
Copy link
Contributor

igalic commented Dec 18, 2015

  • make module: rake tasks invisible by default
  • change travis_release to a more speaking name like, puppet_community_release
  • after module:bump_commit, puppet_community_release should append -rc to our metada.json version
@rnelson0
Copy link
Member

I think I see how the last step works, but can you elaborate on the desired workflow?

If it's what I think, the rake task that travis calls should check for -rc and call it a day if it finds it, rather than wasting time erroring out at the forge (I hope that errors!).

@igalic
Copy link
Contributor Author

igalic commented Dec 20, 2015

i very much hope that blacksmith's module:bump does the sensible thing and makes 1.2.3-rc into 1.2.4, if not, that's a bug in the semver gem.

@igalic
Copy link
Contributor Author

igalic commented Dec 21, 2015

all done as per voxpupuli/voxpupuli.github.io#21
we're now trying to figure out if that works.
unfortunately, it appears to require a working ruby :D

@igalic
Copy link
Contributor Author

igalic commented Jan 4, 2016

after the (two;) successful release(s) of puppet-extlib (voxpupuli/puppet-extlib#45 & voxpupuli/puppet-extlib#43) we should migrate the rake task into this repository. (see also voxpupuli/puppet-blacksmith#25 )

@rnelson0
Copy link
Member

rnelson0 commented Jan 4, 2016

Actually, I'd love to have this option for my own modules. Could it be put into a ruby gem and included via Gemfile and spec/spec_helper.rb?

@igalic
Copy link
Contributor Author

igalic commented Jan 4, 2016

i thought about making it a task of blacksmith, but i'm not sure that's a good idea…


making it its own gem is a possibility, but then we're very bound to blacksmith…
also, that check changelog task… would have to be a block/yield.

@rnelson0
Copy link
Member

rnelson0 commented Jan 4, 2016

Probably not since it hides some tasks. But as a standalone that requires
blacksmith it could be useful when someone wants to opt in

Rob Nelson
rnelson0@gmail.com

@igalic
Copy link
Contributor Author

igalic commented Jan 4, 2016

nod thanks for the feedback here, @rnelson0!

@igalic
Copy link
Contributor Author

igalic commented Mar 24, 2016

i think this is solid by now and can be closed

@igalic igalic closed this as completed Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants