Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include the correct nodesets depending on the module's supported O/S #385

Closed
TraGicCode opened this issue Sep 24, 2017 · 2 comments
Closed

Comments

@TraGicCode
Copy link
Contributor

TraGicCode commented Sep 24, 2017

It would be nice to have windows and/or linux node sets included with modules when they support the given platform. For Example, It doesn't make sense to have linux node sets with a module that will only ever work on windows and it's not really feasable and/or maintainable to add the exclusion of all the nodesets to the module's .sync.yaml. I propose we do the following which is what puppetlabs is currently doing in their modulesync configs

https://github.com/puppetlabs/modulesync_configs/blob/d1f5f9caf0607e707eeed4e95f6a957e6dcaa8df/config_defaults.yml#L1-L46

@bastelfreak
Copy link
Member

It is a good idea to clean this up and only apply nodesets that actually work. I'm not sure about the best way to do this. My main concern is described in #187. The puppetlabs approach would add another list of modules that we need to maintain.

@ekohl
Copy link
Member

ekohl commented Nov 17, 2020

76e6cb2 removed the last nodeset. We're now only relying on beaker-hostgenerator.

@ekohl ekohl closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants