New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define PR/MR label behavior #176

Open

mhutter opened this issue Jun 2, 2020 · 0 comments

Contributor

mhutter commented Jun 2, 2020 •

edited by bittner

Loading

One thing that caught my eye during #175

The GitLab implementation will ensure the configured labels are added to the PR when the PR is created, but will NOT add any labels if there is already an open PR around.
The GitHub implementation will always update the existing PR - and fail horribly from looking at the code (note this was already broken before the PR)

How should the behavior be?

Only ensure the label is set when creating the MR/PR and be done with it
Ensure the specified labels are set even if an MR/PR is already present

I can send a PR for the actual changes.

bittner mentioned this issue

Fix NoMethodError for --pr option (caused by module_options = nil) / introduce --noop #188

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment