-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to handle promise that is resolved before promise is returned #76
Comments
this has just bitten me also. it would be better a "proper" promise ( like jquery Deferred or any of the commonjs promise types ) was used. |
This is really a documentation bug. We don't have promises per-se, this is actually a left-over from when We should update our code to be "emitter" everywhere. |
Added the website tag because the vowsjs.org website has "promise" in a lot of example code. |
Fixed in 73872a8. Will open a corresponding bug on the website. |
is it possible to add an example to the docs that show how one would use Vows.js with a promise-library such as Bluebird? I've tried to use Bluebird's asCallback functionality which kinda works, but there's also the EventEmitter strategy that Vows.js provides but I'm not sure how it would fit in with promises. Thanks for the work you've done on this library, it's been really helpful! |
One problem with using event emitters as promises is that there is no way to find out if an event has been emitted already or not. So, using an event emitter as a promise is problemmatic if the promise has been fulfilled prior to the return from the execution of the topic, i.e. the asynchronous code is actually executed synchronously.
The text was updated successfully, but these errors were encountered: