Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data from the underlying API not exposed by SDK classes #153

Open
neilbenn opened this issue Jul 8, 2024 · 0 comments
Open

Data from the underlying API not exposed by SDK classes #153

neilbenn opened this issue Jul 8, 2024 · 0 comments

Comments

@neilbenn
Copy link

neilbenn commented Jul 8, 2024

  1. client.qualifications().checkEligibility() accepts an option to expand redeemables, but the expanded values do not appear to be available in CheckEligibilityResponse.getRedeemable().getData().

     private static final Option EXPAND_REDEEMABLES_OPTION = Option.builder().expand(List.of(Expand.REDEEMABLE)).build();
     ...
      Customer customer = toVoucherifyCustomer(company);
     CheckEligibility check = CheckEligibility
             .builder()
             .customer(customer)
             .scenario(Scenario.AUDIENCE_ONLY)
             .option(EXPAND_REDEEMABLES_OPTION)
             .build();
    
     CheckEligibilityResponse eligibility = client.qualifications().checkEligibility(check);
    

RedeemableDataResponse does not have a getName or getBanner ... even though these values are returned in the underlying API call.

  1. client.stackables().validate does not appear to expose the applied_discount_amount property in the OrderResponse class, even though the value is present in the underlying API call to /v1/validations. The equivalent OrderItemResponse.getAppliedDiscountAmount() is there, but OrderResponse just has getDiscountAmount() and no getAppliedDiscountAmount().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant