Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left button margins do not match value for right aligned buttons. #206

Closed
webdevmario opened this issue Aug 7, 2023 · 2 comments · Fixed by #221
Closed

Left button margins do not match value for right aligned buttons. #206

webdevmario opened this issue Aug 7, 2023 · 2 comments · Fixed by #221

Comments

@webdevmario
Copy link

I upgraded from v10.0.0 to v11.0.0, set the new provider with a stack type of "js" per my react navigation settings and noticed that the margins for right side buttons is significantly larger than that of left side buttons. This is fine on v10.0.0. Was this intentional?

https://github.com/vonovak/react-navigation-header-buttons/blob/master/src/ButtonsWrapper.tsx
@vonovak
Copy link
Owner

vonovak commented Oct 13, 2023 •
edited
Loading

Hello and thanks for asking,
I believe the margins should be correct, if you think it looks odd, can you share a screenshot?
Thank you 🙂

@DreamGamer
Copy link

Same issue here on Android and IOS:
signal-2023-10-18-030231_002

@vonovak vonovak mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve styles for items on the left in JS stack vonovak/react-navigation-header-buttons
3 participants
@vonovak @webdevmario @DreamGamer