Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper CTA about install vs pin is confusing when not in a project #1847

Closed
charlespierce opened this issue Aug 15, 2024 · 0 comments · Fixed by #1848
Closed

Helper CTA about install vs pin is confusing when not in a project #1847

charlespierce opened this issue Aug 15, 2024 · 0 comments · Fixed by #1848

Comments

@charlespierce
Copy link
Contributor

In #1417, we added additional text to the success message after running volta install that has a call-to-action for using volta pin to change a local project's pinned version.

However, this text is always shown, regardless of whether the command is run from a project or not. It's a bit confusing to see that CTA when you run volta install node initially to set up a default version and aren't in a project.

Based on the underlying issue (#1311), I believe the core issue is actually that the info_project_version text isn't clear what the user can do to resolve the problem. I suspect we should move that additional text over to info_project_version, so that it's shown only when in a project that has a pinned version.

Additionally, right now it's using the full Node + npm version, so recommends an invalid command, e.g.:

to use node@20.16.0 (with npm@10.8.1) in this project run `volta pin node@20.16.0 (with npm@10.8.1)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant