Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide another way to sign certificates for volcano admission controller #649

Closed
hzxuzhonghu opened this issue Dec 27, 2019 · 7 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@hzxuzhonghu
Copy link
Collaborator

hzxuzhonghu commented Dec 27, 2019

/kind feature

Currently, we use this script to create a csr and use kubernetes to sign the certificate,
https://github.com/volcano-sh/volcano/blob/master/installer/dockerfile/webhook-manager/gen-admission-secret.sh

However, there are at least two users reported failure installing volcano with certificate not found. https://volcano-sh.slack.com/archives/CGEDAT353/p1577347378003400, this is mainly caused by vendor customized k8s.

So i would propose to provide another way to generate a certificate, maybe with openssl or CFSSL

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 27, 2019
@hzxuzhonghu
Copy link
Collaborator Author

/cc @RainbowMango

@k82cn
Copy link
Member

k82cn commented Dec 27, 2019

@hzxuzhonghu , I'd like to know the root cause of the issue? for example, does k8s support current way? how can we sure openssl & cfssl can resolve the problem?

@hzxuzhonghu
Copy link
Collaborator Author

BY the tool, we donot rely on k8s to sign a certificate, so definitely this can be resolved

@hzxuzhonghu
Copy link
Collaborator Author

/cc @nicklhy

@k82cn k82cn added this to the v0.4 milestone Dec 27, 2019
@k82cn
Copy link
Member

k82cn commented Feb 10, 2020

what''s next steps?

@hzxuzhonghu
Copy link
Collaborator Author

@RainbowMango Are you still interested in this ?

@hzxuzhonghu
Copy link
Collaborator Author

This is done in #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants