Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels key can not contain '/' #62

Closed
hzxuzhonghu opened this issue Apr 3, 2019 · 2 comments
Closed

Labels key can not contain '/' #62

hzxuzhonghu opened this issue Apr 3, 2019 · 2 comments

Comments

@hzxuzhonghu
Copy link
Collaborator

volcano/pkg/controllers/job/job_controller_util.go

Lines 153 to 154 in 3632d36

pod.Labels[vkv1.JobNameKey] = job.Name
pod.Labels[vkv1.JobNamespaceKey] = job.Namespace

It looks this label is used for service, also I am not sure what is job service for.
@k82cn
Copy link
Member

k82cn commented Apr 4, 2019

Labels key can not contain '/'

How about kubernetes.io/arch=amd64?

xref https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/#kubernetes-io-os

It's a headless service to publish node name of each pod.

@hzxuzhonghu
Copy link
Collaborator Author

Oh, i remember wrongly, const dns1123LabelFmt string = "[a-z0-9]([-a-z0-9]*[a-z0-9])?" is for name validation

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hzxuzhonghu @k82cn