Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deduplicate function in API would break on calling #1418

Open
atcuno opened this issue Dec 17, 2024 · 1 comment · May be fixed by #1421
Open

deduplicate function in API would break on calling #1418

atcuno opened this issue Dec 17, 2024 · 1 comment · May be fixed by #1421
Assignees
@ikelos
Labels
parity-release

Comments

@atcuno
Copy link
Contributor

atcuno commented Dec 17, 2024

This function is really broken:

https://github.com/volatilityfoundation/volatility3/blob/develop/volatility3/framework/contexts/__init__.py#L395

as in the loop , mod will be a str but then it looks at hash and size members that do not exist.

It doesn't seem like this function is used in any of the current code, but it does look like it would be a public API.

The method should either be fixed or removed it seems?

This is definitely in your realm @ikelos
ikelos added a commit that referenced this issue Dec 17, 2024
@ikelos
Core: Start to fix up the typing in ModuleCollection
f0f3bb6 
Fixes #1418
@ikelos ikelos linked a pull request Dec 17, 2024 that will close this issue
Open
@atcuno
Copy link
Contributor Author

atcuno commented Dec 17, 2024

Thanks!

I am going through the whole framework with pyright, error-by-error (1500+ reported but many aren't real).. so we can kill off as many of these statically detectable bugs before the big parity testing over hundreds of samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikelos ikelos

Labels
parity-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/issue1418 volatilityfoundation/volatility3
2 participants
@atcuno @ikelos