-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VoilaExecutePreprocessor.allow_errors always True #519
Comments
Good catch, thanks @jeffyjefflabs. Voila handles Line 148 in 919d57d
Which seems to be shadowing the |
I am working on this today |
It comes from #186, I feel like this PR should not have been merged as it shadows the |
Although I agree with the initial intention of this PR. Maybe we should set |
I agree, since this looks to be controllable from nbconvert, voila should not add similar behavior. Maybe allow_error should be set to True on debug? |
What I have in mind is to overwrite the And in the case of having |
Sound good I think, maybe we can use this pattern: Line 62 in 919d57d
|
Completely overwriting the trait would allow writing the right documentation in allow_errors = Bool(
True,
help=dedent(
"""
If `True` (default), execution errors are ignored and the execution
is continued until the end of the notebook. Output from
exceptions is included in the cell output only if Voila is run with --debug.
If `False`, when a cell raises an error the
execution is stopped and a `CellExecutionError`
is raised.
"""
)
).tag(config=True) |
I remember this being an issue actually, not 100% sure it is related: jupyter/nbconvert#1056 (comment) |
I am not sure I understand the comment on your link, what was the issue? |
If you add --allow-errors to aliases (like in jupyter/nbconvert@e78f02e) traitlets gets confused which class to alias this to. But as long as we don't make it an alias we should be fine. |
Thanks for looking into this! I tried your PR #530 and it works for me. I like keeping |
If a cell throws an exception, the cells after it are still being executed. Setting allow_errors explicitly to False (which is the default anyway) doesn't affect it.
The text was updated successfully, but these errors were encountered: