Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for other kernel_spec_manager classes #1403

Closed
ClaytonAstrom opened this issue Oct 3, 2023 · 1 comment · Fixed by #1404
Closed

Allow for other kernel_spec_manager classes #1403

ClaytonAstrom opened this issue Oct 3, 2023 · 1 comment · Fixed by #1404
Labels
enhancement New feature or request

Comments

@ClaytonAstrom
Copy link
Contributor

Problem

kernel_spec_manager is hardcoded to a jupyter_client KernelSpecManager instance, not allowing for async or other managers - https://github.com/voila-dashboards/voila/blob/main/voila/app.py#L547

Proposed Solution

  • Expose the top level kernel_spec_manager to the VoilaConfiguration
@ClaytonAstrom ClaytonAstrom added the enhancement New feature or request label Oct 3, 2023
@martinRenou
Copy link
Member

Thank you for opening an issue! Making this configurable could be nice indeed. Would you be willing to try opening a PR for this?

@ClaytonAstrom ClaytonAstrom mentioned this issue Oct 3, 2023
Merged
@ClaytonAstrom ClaytonAstrom changed the title Allow for other kernel_spec_manager classes #1403 Allow for other kernel_spec_manager classes Oct 3, 2023
@ClaytonAstrom ClaytonAstrom changed the title #1403 Allow for other kernel_spec_manager classes Allow for other kernel_spec_manager classes Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for custom kernel_spec_manager class ClaytonAstrom/voila
2 participants
@ClaytonAstrom @martinRenou