-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using --enable_nbextensions=True in v0.3.2 shows an error in console #1107
Comments
What is your nbconvert version? |
This error
is really odd. Are you sure you are running |
nbconvert: 6.4.2 All versions:
|
This environment looks ok... I am not able to reproduce your issue with almost the same environment.
|
Would you be able to add prints around here? Line 147 in 6be66cc
To make sure this function is called. This is the one that adds the |
|
I don't get what the issue is. So you're saying it is not happening if you're not passing |
| So you're saying it is not happening if you're not passing --enable_nbextensions=True? Indeed. |
But you can't re produce it, so it could be something with my environment? |
Yes, I am not able to reproduce, on my side it works with and without Maybe we should focus more on the origin of
Would you be able to add a print statement line 860 of Also, I see something interesting in your logs. It looks like it is failing to render the
which I believe is a bug in Voila that we should fix. We probably don't call |
Confirmed with printing that
|
I tried it on linux and can't reproduce it there. Also, the So it seems the combination of macOS + |
Thank you for specifying this. I'll try on MacOS. EDIT: It looks like I am not able to reproduce on MacOS. It seems to work as intended.
|
@mariobuikhuizen would you be able to try this PR? #1108 Hopefully you should see a more meaningful error with this PR that could help us. You will probably just see a 404 error page, but then I would be interested to know what URL you are looking at. |
Thanks! I tried your PR, but still have the same error and also no 404 on the page. I did now notice that I had an error about an extension I had used a while ago but is not in this environment. Turns out that was the culprit: it had made a file: {
"load_extensions": {
"execute_time/ExecuteTime": true,
"jupyter-js-widgets/extension": true
},
"ExecuteTime": {
"clear_timings_on_clear_output": true
}
} Removing this file fixes the error. |
Oh yeah those global paths can be annoying sometimes... Happy that you could find your issue! |
Thanks for the help! |
These shouldn't cause voila not to work btw. Yes you get error messages in the JS console, because these are nbextensions loaded outside of a notebook context, but that shouldn't matter, so I think there is still a bug. |
@mariobuikhuizen was it causing Voila to not work or were you just getting a 404? |
It did work, only an error in the console. |
I also see these errors when using voila-embed. That somehow tries to load |
Ok. I tried locally and can reproduce your issue now. I believe it should only show a 404 error and not that part though:
|
1ba7791 should prevent this error. Testing locally, I only see the 404 error now:
|
Any idea why this is related to the extensions? Or is it not? |
It's just a 404 error because the nbextension is not found, it does not prevent the Notebook to render. |
It works, thanks! A problem with the 404 errors in the log is that sometimes the missing file can be expected. E.g. in https://github.com/mariobuikhuizen/voila-embed a
(but this is probably never a problem in the "normal" use of Voila) |
They shouldn't cause any issues, it's just that the browser will try to fetch the source maps, I think you don't see those in the dev console network tab even. |
Description
Using
--enable_nbextensions=True
in v0.3.2 shows an error in console:Reproduce
mamba create -n voila32 -c conda-forge voila=0.3.2 ipywidgets; conda activate voila32
voila --enable_nbextensions=True empty_notebook.ipynb
Context
The text was updated successfully, but these errors were encountered: