Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING] Updates blocked on Rust 1.65.0 #40805

Closed
19 of 20 tasks
jcgruenhage opened this issue Nov 27, 2022 · 25 comments
Closed
19 of 20 tasks

[TRACKING] Updates blocked on Rust 1.65.0 #40805

jcgruenhage opened this issue Nov 27, 2022 · 25 comments
Labels
tracking for tracking larger sets of changes

Comments

@classabbyamp classabbyamp added the tracking for tracking larger sets of changes label Nov 27, 2022
@icp1994
Copy link
Contributor

icp1994 commented Nov 27, 2022

rust-analyzer and qsv are two that I know of

@jcgruenhage
Copy link
Contributor Author

Isn't rust-analyzer shipped by rustup though? Not sure whether it makes sense to ship that separately. We removed rustfmt back when it started being shipped by rustup, although that had additional reasons related to requiring nightly iirc.

@icp1994
Copy link
Contributor

icp1994 commented Nov 27, 2022

From the 1.64 release blog

At this time, to run the rustup-installed version, you need to invoke it this way: rustup run stable rust-analyzer
The next release of rustup will provide a built-in proxy so that running the executable rust-analyzer will launch the appropriate version.

Most users should continue to use the releases provided by the rust-analyzer team (available on the rust-analyzer releases page), which are published more frequently

Not exactly sure what should be done regarding the RA package after the next rustup update but okay maybe it can left from the list for now.

@jcgruenhage
Copy link
Contributor Author

Ah, okay, so we still need rust-analyzer until we get a new rustup release at least.. In that case, I think we should add it to the list here.

@0x5c
Copy link
Contributor

0x5c commented Nov 27, 2022

Unless we mark the rust toolchain packages as "for package building only", there will be people using the rust toolchain bits we ship instead of whatever they'd otherwise download through rustup.

The current setup allows all the toolchain to be installed through xbps without rustup involvement, no mix needed. People using packaged rust with rustup-downloaded r-a won't even get the same version unless they specifically ensure they keep the packaged rust and rustup r-a in version sync.

I don't personally use packaged rust outside of when packaging other things, and I'm not sure using packaged rust is good for development purposes, but such is the current state of what we ship.

@icp1994
Copy link
Contributor

icp1994 commented Nov 30, 2022

nushell

@icp1994
Copy link
Contributor

icp1994 commented Dec 13, 2022

pueue >= 3.0.0

@cinerea0
Copy link
Contributor

cinerea0 commented Jan 2, 2023

bottom >= 0.7.0 requires let-else statements which were stabilized in 1.65.

@leahneukirchen
Copy link
Member

I want to package prose but a depenency needs 1.65.

@cinerea0
Copy link
Contributor

cinerea0 commented Jan 4, 2023

broot >= 1.19.0 requires 1.65.

@tranzystorekk
Copy link
Contributor

zoxide >= 0.9.0

@cinerea0
Copy link
Contributor

ouch >= 0.4.1 requires let-else statements.

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Jan 15, 2023

Preliminary test on llvm15/rust 1.66.1/x86_64-glibc:

  • cargo-about 0.5.2
  • qsv 0.84.0
  • rust-analyzer 2023.01.09
  • nushell 0.74.0 (haven't yet updated system libs patch)
  • pueue 3.1.1 (fails to build due to darwin-libproc: http://ix.io/4lkO)
  • bottom 0.7.1
  • broot 1.19.0
  • zoxide 0.9.0
  • cargo-deny 0.13.7
  • ouch 0.4.1
  • prose 0.4.0

@classabbyamp
Copy link
Member

helvum >= 0.4.0 (let-else statements) (classabbyamp@4d1222b)

@cinerea0
Copy link
Contributor

Kooha >= 2.2.3 uses let-else statements all over the place.

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Feb 26, 2023

#40600 atuin >= 13.0.0, let-else statements

@cinerea0
Copy link
Contributor

mdcat >= 1.1.0 requires GATs, which were stabilized in rust 1.65.

@classabbyamp
Copy link
Member

rbw 1.6.0, let else statements

@tranzystorekk
Copy link
Contributor

new package fend >= 1.1.5, let-else statements

@icp1994
Copy link
Contributor

icp1994 commented Mar 15, 2023

procs >= 0.14.0 [msrv 1.67]

@leahneukirchen
Copy link
Member

I want to package typst but a dependency uses let..else.

@TinfoilSubmarine
Copy link
Contributor

vaultwarden-1.28.0 needs argon2 v0.5.0 which requires rustc >= 1.65:

error: package `argon2 v0.5.0` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.64.0

@0xlua
Copy link
Contributor

0xlua commented Mar 30, 2023

ncspot >= 0.12.0 uses the backtrace api which was stabilized in rust 1.65

@tranzystorekk
Copy link
Contributor

helix >= 23.03, MSRV set to 1.65

@classabbyamp
Copy link
Member

new rust merged, get em while they're fresh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking for tracking larger sets of changes
Projects
None yet
Development

No branches or pull requests

9 participants