Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved run programmatically #84

Merged
merged 6 commits into from
Apr 17, 2022
Merged

Conversation

luwol03
Copy link
Member

@luwol03 luwol03 commented Apr 2, 2022

Status Type Env Vars Change
✅ Ready Refactor No

Description

This refactores the run programmatically options and exposes a lot more functionallity from the createServer method.

Motivation and Context

It always bothered me, that the function which creates the server also starts it and there is no possibility to only create.

Screenshots / GIFs (if appropriate):

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

@luwol03 luwol03 added the kind/improvement Code improvement label Apr 2, 2022
@luwol03 luwol03 added this to the v1.3.0 milestone Apr 2, 2022
@luwol03 luwol03 self-assigned this Apr 2, 2022
luwol03 added a commit to vocascan/documentation that referenced this pull request Apr 2, 2022
@luwol03 luwol03 requested a review from noctera April 3, 2022 08:17
@luwol03 luwol03 requested a review from noctera April 17, 2022 09:43
@luwol03 luwol03 merged commit 4830859 into experimental Apr 17, 2022
@luwol03 luwol03 deleted the improve-run-programmatically branch April 17, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvement
Projects
Status: 🚀 Ready
Development

Successfully merging this pull request may close these issues.

2 participants