Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS #71

Merged
merged 3 commits into from
Dec 31, 2021
Merged

CORS #71

merged 3 commits into from
Dec 31, 2021

Conversation

luwol03
Copy link
Member

@luwol03 luwol03 commented Dec 30, 2021

Status Type Env Vars Change
✅ Ready Feature Yes

Description

This PR adds the ability to configure cors headers.

Motivation and Context

This is needed for the hosted frontend version to work.

Screenshots / GIFs (if appropriate):

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

@luwol03 luwol03 added the kind/enhancement New feature or request label Dec 30, 2021
@luwol03 luwol03 requested a review from noctera December 30, 2021 14:28
@luwol03 luwol03 changed the title added cors origin config option CORS Dec 30, 2021
@noctera
Copy link
Member

noctera commented Dec 30, 2021

Could you update the example configs, please?

@luwol03
Copy link
Member Author

luwol03 commented Dec 30, 2021

Could you update the example configs, please?

Sorry, totally forgot that. Added now.

@luwol03 luwol03 merged commit b889acc into experimental Dec 31, 2021
@luwol03 luwol03 deleted the feature/cors branch December 31, 2021 22:24
@luwol03 luwol03 added this to the v1.2.0 milestone Jan 16, 2022
@luwol03 luwol03 self-assigned this Jan 16, 2022
@luwol03 luwol03 linked an issue Jan 16, 2022 that may be closed by this pull request
bug/cors-error #57
Closed
@luwol03 luwol03 mentioned this pull request Jan 18, 2022
Closed
luwol03 added a commit that referenced this pull request Jan 22, 2022
@luwol03
CORS (#71)
340bdf3 
* added cors origin config option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noctera noctera noctera approved these changes

Assignees

@luwol03 luwol03

Labels
kind/enhancement New feature or request
Projects
Todo
Status: 🚀 Ready
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

bug/cors-error
2 participants
@luwol03 @noctera