Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The repo maintenance job should support node selector #7758

Closed
reasonerjt opened this issue Apr 30, 2024 · 2 comments · Fixed by #8145
Closed

The repo maintenance job should support node selector #7758

reasonerjt opened this issue Apr 30, 2024 · 2 comments · Fixed by #8145

Comments

@reasonerjt
Copy link
Contributor

The repository maintenance jobs may be running for some time and consume substantial resource.

Like datamover, we should support node-selector for these jobs. Ideally we should reuse the data structures of node selectors for data mover and provide a similar user experience in terms of setting the node selectors.

@blackpiglet
Copy link
Contributor

IMO, reuse the ConfigMap mentioned in this design to generate the maintenance Job is enough.

I am checking with the issue reporter whether that is acceptable.

@reasonerjt reasonerjt added this to the v1.15 milestone Jul 10, 2024
@blackpiglet
Copy link
Contributor

First, if we create a configuration for the repository maintenance Job, related information should be all put there, not only the node selector, for example, the Job's resource configuration should be considered too.

Second, is it reasonable to make the node selection configuration per BackupRepository? It's a bit overkill for the node selection, but the resource configuration could differ for different BackupRepositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants