Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile target to help create changelog file. #7865

Closed
kaovilai opened this issue Jun 6, 2024 · 6 comments · Fixed by #8104
Closed

Makefile target to help create changelog file. #7865

kaovilai opened this issue Jun 6, 2024 · 6 comments · Fixed by #8104

Comments

@kaovilai
Copy link
Contributor

kaovilai commented Jun 6, 2024

Describe the problem/challenge you have

Makes it easier to correctly add new unreleased changelogs to correct dir.

Describe the solution you'd like

A placeholder file that will persists the changelogs/unreleased dir

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@reasonerjt
Copy link
Contributor

I believe you can create the unreleased dir when you wanna add the first changelog file after branch cut?

@kaovilai
Copy link
Contributor Author

I could yes. but it could be error prone as I could mistype unreleased.
An alternative would be a script to generate this dir.

Not a big issue. I could add my script to one of the gitignore dirs.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@kaovilai kaovilai mentioned this issue Aug 11, 2024
Merged
3 tasks
@kaovilai kaovilai changed the title changelogs dir should have unreleased dir in git Makefile target to help create changelog file. Aug 11, 2024
@kaovilai
Copy link
Contributor Author

unstale? if the change in #8104 is ok with you.

@github-actions github-actions bot removed the staled label Aug 12, 2024
@mateusoliveira43
Copy link
Contributor

I would try to automate process #6514 (comment)

@kaovilai
Copy link
Contributor Author

I have made my own zsh function to complete this functionality.. so I am closing this issue but will leave PR open for discussion.

Any automations enhancements per #6514 should be brought up as a separate new issue.

@kaovilai kaovilai closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new-changelog to Makefile kaovilai/velero
3 participants
@reasonerjt @kaovilai @mateusoliveira43