Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade robfig/cron Library to Support Time Zones #7792

Closed
yuanqijing opened this issue May 14, 2024 · 2 comments · Fixed by #7793
Closed

Upgrade robfig/cron Library to Support Time Zones #7792

yuanqijing opened this issue May 14, 2024 · 2 comments · Fixed by #7793

Comments

@yuanqijing
Copy link

Describe the problem/challenge you have

Currently, Velero uses robfig/cron library version v1.1.0 which does not support time zone specification for scheduled tasks. Upgrading to robfig/cron version v3.0.0 or higher will allow us to leverage time zone features, providing more flexibility in scheduling backups and other tasks based on different time zones.

Describe the solution you'd like

To implement this feature, the robfig/cron library should be upgraded to v3.0.0 or higher.

Anything else you would like to add:

Here's an example of how the updated cron scheduling might look with time zone support:
velero schedule create NAME --schedule="CRON_TZ=Asia/Tokyo 30 04 * * *"

References:
robfig/cron v3 documentation

Environment:

  • Velero version (use velero version): Version: v1.13.2
  • Kubernetes version (use kubectl version): v1.22.15
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@blackpiglet
Copy link
Contributor

unstale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants