Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain "passing" CII Best Practices badge #989

Closed
antoninbas opened this issue Jul 29, 2020 · 1 comment · Fixed by #1618
Closed

Obtain "passing" CII Best Practices badge #989

antoninbas opened this issue Jul 29, 2020 · 1 comment · Fixed by #1618
Assignees
@antoninbas
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@antoninbas
Copy link
Contributor

The badge (https://bestpractices.coreinfrastructure.org/en) relies on a self-certification process. To obtain a "passing" badge, a set of criteria must be met (additional criteria for the "silver" and the "gold" badges). Antrea already meets a lot of them, but looking at the remaining ones, addressing potential issues, and obtaining a badge is a good way to make the project even better. The CII Best Practices focus on contributor onboarding, CI, review process, source version control and security.

Note that the "passing" badge is actually a requirement for "graduated" CNCF projects. If we want Antrea to be considered for the "sandbox" maturity level, it may still be a good idea to obtain the badge now.
@antoninbas antoninbas self-assigned this Jul 29, 2020
@antoninbas
Copy link
Contributor Author

I have started a CII Best practices project here: https://bestpractices.coreinfrastructure.org/en/projects/4173

@antoninbas antoninbas added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 29, 2020
antoninbas added a commit to antoninbas/antrea that referenced this issue Jul 31, 2020
@antoninbas
Add new linters
74b7163 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see antrea-io#989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
@antoninbas antoninbas mentioned this issue Jul 31, 2020
Merged
antoninbas added a commit to antoninbas/antrea that referenced this issue Jul 31, 2020
@antoninbas
Add new linters
b446608 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see antrea-io#989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
antoninbas added a commit to antoninbas/antrea that referenced this issue Jul 31, 2020
@antoninbas
Add new linters
fa72f7f 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see antrea-io#989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
antoninbas added a commit to antoninbas/antrea that referenced this issue Jul 31, 2020
@antoninbas
Add new linters
049d11f 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see antrea-io#989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
antoninbas added a commit that referenced this issue Aug 4, 2020
@antoninbas
Add new linters
9ae1a7d 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see #989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
@antoninbas antoninbas mentioned this issue Aug 19, 2020
Closed
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 21, 2020
@antoninbas
Update documentation
621bc05 
 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 21, 2020
@antoninbas
Update documentation
e5d0c78 
 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989
@antoninbas antoninbas mentioned this issue Aug 21, 2020
Merged
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 21, 2020
@antoninbas
Update documentation
1378881 
 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 22, 2020
@antoninbas
Update documentation
9b70e7c 
 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989
antoninbas added a commit to antoninbas/antrea that referenced this issue Aug 25, 2020
@antoninbas
Update documentation
f0db15f 
 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989
antoninbas added a commit that referenced this issue Aug 26, 2020
@antoninbas
Update documentation (#1136)
4ed2c67 
* Update documentation

 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   #989

* Address review comments
@antoninbas antoninbas mentioned this issue Sep 22, 2020
Closed
GraysonWu pushed a commit to GraysonWu/antrea that referenced this issue Sep 22, 2020
@antoninbas @GraysonWu
Add new linters
066768b 
We enable the staticcheck and gosec linters in golangci-lint.
The most important one here is gosec, as it will be useful when
answering questions for the CII Best Practices self-certification
questionnaire (see antrea-io#989).

Running these linters did not reveal any noticeable issue in the Antrea
codebase.
GraysonWu pushed a commit to GraysonWu/antrea that referenced this issue Sep 22, 2020
@antoninbas @GraysonWu
Update documentation (antrea-io#1136)
d3f290e 
* Update documentation

 * add missing linters
 * emphasize that new test cases should be added as part of new
   contributions and include more details about the different categories
   of tests we support; this is related to
   antrea-io#989

* Address review comments
antoninbas added a commit to antoninbas/antrea that referenced this issue Dec 4, 2020
@antoninbas
Display CII best practice badge in README
dcaeb73 
Fixes antrea-io#989
@antoninbas antoninbas mentioned this issue Dec 4, 2020
Merged
antoninbas added a commit that referenced this issue Dec 8, 2020
@antoninbas
Display CII best practice badge in README (#1618)
79b0457 
Fixes #989
antoninbas added a commit that referenced this issue Dec 23, 2020
@antoninbas
Display CII best practice badge in README (#1618)
def01b1 
Fixes #989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display CII best practice badge in README antoninbas/antrea
1 participant
@antoninbas