-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: BERT models for embeddings #5179
Comments
Yep - we would welcome a PR |
Sounds fun! I'm on this Thanks! |
I also have interest in this task. Referring to #3734, I just use transformers.BertModel to implement the BertEmbeddingModel class(main...laishzh:vllm:feat/bert). The code is in very early version, but it can output the embedding which I think is wrong~ The reason maybe is that the weights are not loaded correctly. This is my first development. I'm not sure whether is the right way to implement, or need to reimplement BertModel? Suggestions or cooperation are welcome. @Etelis Also hope it helps. |
The main thing you have to do is implement the You can look at how llama and others are implemented in that directory as inspiration |
Now with the introduction of embeddings: #3734, are there plans on the roadmap to support BERT models?
The text was updated successfully, but these errors were encountered: