Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S-LoRA] Something is wrong with the s-lora arguments in server_api #3174

Closed
sleepwalker2017 opened this issue Mar 4, 2024 · 6 comments
Closed
Labels
stale Over 90 days of inactivity

Comments

@sleepwalker2017
Copy link
Contributor

I notice that there is no --lora-modules argument in the vllm.entrypoints.api_server, which means I must add the lora local path when sending request.

That's unrealistic. Because the client doesn't know the lora path.

Any plan to fix it ?

@sleepwalker2017 sleepwalker2017 changed the title [S-LoRA] Something wrong with the s-lora arguments in server_api [S-LoRA] Something is wrong with the s-lora arguments in server_api Mar 4, 2024
@simon-mo
Copy link
Collaborator

simon-mo commented Mar 4, 2024

Please use the vllm.entrypoints.openai.apI_server instead, which have similar functionality and OpenAI compatible API.

@sleepwalker2017
Copy link
Contributor Author

Please use the vllm.entrypoints.openai.apI_server instead, which have similar functionality and OpenAI compatible API.

thank you. Is there any script to benchmark the multiple lora serving?

Copy link
Collaborator

simon-mo commented Mar 6, 2024

I don't believe we have a full benchmark on LoRA. Please check out what we have in benchmarks/ in the repo and contribution welcomed!

@sleepwalker2017
Copy link
Contributor Author

sleepwalker2017 commented Mar 6, 2024

I don't believe we have a full benchmark on LoRA. Please check out what we have in benchmarks/ in the repo and contribution welcomed!

ok, I find some performance issues and post it here #3219.

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Oct 30, 2024
Copy link

This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Over 90 days of inactivity
Projects
None yet
Development

No branches or pull requests

2 participants