Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compile source code error for ROCM platform when using #include <hip/hip_bf16.h> #2725

Closed
lhcalibur opened this issue Feb 2, 2024 · 3 comments · Fixed by #2790
Closed

Comments

@lhcalibur
Copy link

lhcalibur commented Feb 2, 2024

As mentioned in ##2646

Building for ROCM platform will cause multiple definition error,

This is caused by The function in <hip/hip_bf16.h> being defined without static inline , which will cause multi definition error when using this header file in multi .cu/.hip files.

#ROCm/HIP#3403

The error will be fixed in future releases of ROCM, but till ROCM-6.0.2, this has not been fixed yet, maybe we need to find a way to bypass this.

Maybe using hip_bfloat16 instead of __hip_bfloat16? #ROCm/ROCm#2534, but needs some code modification.

@jamestwhedbee
Copy link
Contributor

Running into this as well

@hongxiayang
Copy link
Collaborator

I am working on a fix for this issue now. Will update when I have a pull request

@hongxiayang
Copy link
Collaborator

Fix for vllm ROCm 6.0 build is here: #2790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants