Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix missing checker for generic array type without concrete types #22416

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 5, 2024

@felipensp felipensp marked this pull request as ready for review October 6, 2024 02:20
@spytheman
Copy link
Member

Good work, but please add a test for the error.

@spytheman
Copy link
Member

Should not it be in the checker, instead of the parser?

@spytheman
Copy link
Member

The problem with it being in the parser, is that the parser has limited type information.
If the types are defined in another .v file in the same module, it will trigger different behaviour, when the check is done in the parser, depending on whether the other .v files are already parsed or not.

If the check is done in the checker, that is much less likely to happen, since everything is already parsed, and the checker will make sure that its analysis is done based on the full type information from all declarations, from all files.

@felipensp
Copy link
Member Author

Should not it be in the checker, instead of the parser?

Yeah, I moved to the parser because on checker the .typ was already resolved to []Callback[T] even when it was used []Callback.

@felipensp felipensp changed the title parser: fix missing checker array generic checker: fix missing checker array generic Oct 6, 2024
@felipensp felipensp changed the title checker: fix missing checker array generic checker: fix missing checker for generic type without concrete types Oct 6, 2024
@felipensp felipensp changed the title checker: fix missing checker for generic type without concrete types checker: fix missing checker for generic array type without concrete types Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing checker error for array of generic sumtype
2 participants