Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension]: sd-webui-wd14-tagger, api/models incompatible #3638

Open
1 task done
kappa8086 opened this issue Dec 18, 2024 · 1 comment
Open
1 task done

[Extension]: sd-webui-wd14-tagger, api/models incompatible #3638

kappa8086 opened this issue Dec 18, 2024 · 1 comment
Labels
extension Extension is not working correctly

Comments

@kappa8086
Copy link

Issue Description

sd-webui-wd14-tagger extension error on running installer

AttributeError: module 'modules.api.models' has no attribute 'InterrogateRequest'

I traced into the code, and found that in git log:

commit 7e44722
Author: Vladimir Mandic mandic00@live.com
Date: Sun Jan 28 10:12:24 2024 -0500

refactor api
    • major public api refactoring
  • this may cause compatibility issues if an extension is doing a direct import from api.py or models.py
  • in which case, report it so we can add a compatibility layer

InterrogateRequest was renamed to ReqInterrogate and was modified in later commits

ps: this extension(& its forks) is not under active maintenance recently but I don't know if there is a similar one, as an alternative

Version Platform Description

Starting SD.Next
Python 3.11.9 on Windows10
Version: app=sd.next updated=2024-12-09
ROCm: AMD toolkit detected
ROCm: version=6.1, using agent gfx1103
Torch: torch==2.3.1+cu118 torchvision==0.18.1+cu118
Extensions: disabled=['sdnext-modernui']
Extensions: enabled=['Lora', 'sd-extension-chainner', 'sd-extension-system-info', 'sd-webui-agent-scheduler', 'stable-diffusion-webui-rembg'] extensions-builtin
Extensions: enabled=['sd-webui-reactor', 'tagger'] extensions

URL link of the extension

https://github.com/picobyte/stable-diffusion-webui-wd14-tagger

URL link of the issue reported in the extension repository

No response

Acknowledgements

  • I have read the above and searched for existing issues
@kappa8086 kappa8086 added the extension Extension is not working correctly label Dec 18, 2024
@vladmandic
Copy link
Owner

your best bet might be to create a fork and update the extension? i don't think its reasonable that extension performs direct access to such internals and i will not downgrade sdnext internal definition to match this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Extension is not working correctly
Projects
None yet
Development

No branches or pull requests

2 participants