Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Fixing of Sampler Flaws (falsely interpolated steps / limiting results to medium brightness) #1268

Closed
TheOnlyHolyMoly opened this issue Jun 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@TheOnlyHolyMoly
Copy link

Feature description

Reminder for conversation (#1091 (reply in thread)) as requested by @vladmandic

Mainly the issue narrows down to issues with the timesteps function leading to a Non-Zero Terminal Noise Ratio, leading to a bias in at least DDIM samplers, but possibly other samplers that follow the timesteps approach.

Details and solution approach captured in above linked discussion thread.

Resources
huggingface/diffusers#2585
DDIM Repo Owner >https://github.com/ermongroup/ddim
Scientific Paper on problems & fixing: https://arxiv.org/abs/2305.08891

Version Platform Description

Affects all platforms

@DirtyHamster
Copy link

There was a live stream going over this paper last week: https://www.youtube.com/watch?v=o1eJAUe-czQ

@TheOnlyHolyMoly
Copy link
Author

Adding in. Looks like diffusers team is working on the same matter.

huggingface/diffusers#3664

@vladmandic
Copy link
Owner

implemented in diffusers, no plan to bring it to original backend at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants