Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Submit to tslint project? #2

Open
abierbaum opened this issue Feb 25, 2019 · 2 comments
Open

Submit to tslint project? #2

abierbaum opened this issue Feb 25, 2019 · 2 comments

Comments

@abierbaum
Copy link

I love this rule. It looks like it addresses a lot of the issues I have been looking to resolve but can't with the normal rules. It also looks like others in the community could make use of it. [1] [2]

Have you thought of submitting it to the tslint project as a base rule?

1: microsoft/tslint-microsoft-contrib#435
2: https://github.com/smikula/good-fences

@vladimiry
Copy link
Owner

looking to resolve but can't with the normal rules

All the rules that implement needed interface are normal rules, including no-import-zones 😄

Have you thought of submitting it to the tslint project as a base rule?

I've not.

I just have looked into the tslint's production/runtime dependencies and located minimatch module in the list. But no-import-zones rule goes with micromatch and I'm not going to replace it with minimatch, see why.

So I doubt tslint team will be happy adding a new micromatch dependency just because some custom rule made it its runtime dependency. But still, I will consider PR-ing no-import-zones rule to the tslint project.

@vladimiry
Copy link
Owner

Looks like tslint is going to be deprecated soon. So I will see how it goes before PR-ing the project somewhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants