Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem after updating to nuget package version 2.33 #436

Closed
rutkowskit opened this issue Aug 22, 2022 · 4 comments
Closed

Problem after updating to nuget package version 2.33 #436

rutkowskit opened this issue Aug 22, 2022 · 4 comments

Comments

@rutkowskit
Copy link
Contributor

rutkowskit commented Aug 22, 2022

Hello,
I think there is something wrong with nuget package 2.33.
After upgrade, my build is breaking on "TapIf" methods.

Was it deleted on purpose?

Downgrading to version 2.32 fixed the problems with compilation.

@vkhorikov
Copy link
Owner

Let me check. Could you please post the code that no longer compiles?

@rutkowskit
Copy link
Contributor Author

I have errors for these missing extensions:

public static Task<Result> TapIf(this Result result, bool condition, Func<Task> action);
public static Task<Result<T>> TapIf<T>(this Task<Result<T>> resultTask, bool condition, Action<T> action);    
public static Task<Result<T>> TapIf<T>(this Task<Result<T>> resultTask, Func<T, bool> condition, Action<T> action);
public static Task<Result<T>> TapIf<T>(this Result<T> result, Func<T, bool> condition, Func<T, Task> action);
public static Result<T> TapIf<T>(this Result<T> result, bool condition, Action<T> action);
public static Result<T> TapIf<T>(this Result<T> result, Func<T, bool> condition, Action<T> action);

I checked in the "Main Branch" code, and it seems that all the "TapIf" was removed in this version (except the obsolete ones), so i guess the problem applies to all "TapIf" extensions.

@vkhorikov
Copy link
Owner

Returned those methods back, a new version 2.33.1 will be published in ~5 minutes, could you please check?

@rutkowskit
Copy link
Contributor Author

Updated to version 2.33.1.
No error during compilation.
Thank You :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants