Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest! #333

Open
hankovich opened this issue Sep 30, 2021 · 13 comments
Open

Hacktoberfest! #333

hankovich opened this issue Sep 30, 2021 · 13 comments

Comments

@hankovich
Copy link
Collaborator

Hi @vkhorikov! Could you please add a hacktoberfest label to the repo?

@vkhorikov
Copy link
Owner

vkhorikov commented Sep 30, 2021

@hankovich

Be ready to review pull requests, approving those that are valid, and flagging those that are not as 'invalid' or 'spam'.

Oof. I'm afraid these reviews will need additional scrutiny compared to what is usually submitted here. And I'll be travelling for most of October, so won't be able to assist much.

Would like to do the reviews yourself? I can make you a collaborator on this repository, which should give you all the required permissions. If you are willing to take on the reviewing/merging process, I'm fine with participating in hacktoberfest.

@hankovich
Copy link
Collaborator Author

I don’t really think it’s going to cause a lot of PRs, but I was planning to participate and I have several ideas to bring in.

Sure, I can try. It will be an honor for me.

@vkhorikov
Copy link
Owner

vkhorikov commented Oct 1, 2021

@hankovich Just made you a collaborator, you should get an invite in your inbox. You should also be able to add all the required labels to this repository now.

@hankovich
Copy link
Collaborator Author

Thanks! But I do not have acces to modify the topics of the repo. As I see here Maintain or Admin permissions are required to manage them.

@vkhorikov Could you you please add it? It's simple.

@vkhorikov
Copy link
Owner

@hankovich I don't see a way to add you as a maintainer via the settings interface.

I've added a Hacktoberfest label, take a look pls.

@hankovich
Copy link
Collaborator Author

@vkhorikov thanks, everything looks correct.

@SamuelViesselman
Copy link
Contributor

@hankovich Do you have an idea of how you want to organize things for people to work on?

I'm willing to help out, but could use some direction

@hankovich
Copy link
Collaborator Author

@SamuelViesselman No, I don't. Probably Vladimir has.
This repo already has the corresponding hacktoberfest topic, so merged PRs will be counted automatiсally.

@vkhorikov
Copy link
Owner

In terms of work -- extension methods for UnitResult are a good start. We need to look at existing extension methods for Result<T, E> and add those that are missing for UnitResult. Here's the corresponding issue: #200

@seangwright
Copy link
Contributor

seangwright commented Oct 12, 2021

I started on documenting Maybe and Result in the README.md. Someone could follow that pattern and add more examples - it might be a good way for a new person to learn the library.

It also looks like the new Maybe/Result.GetValue... methods weren't added to the examples - .Unwrap() is still listed there.

@hankovich
Copy link
Collaborator Author

hankovich commented Oct 9, 2022

Hi @vkhorikov! It's October and the Hacktoberfest is in full swing. Could you please add a hacktoberfest label to the repo? Only owners can edit labels.

@vkhorikov
Copy link
Owner

@hankovich Added. Please check.

@hankovich
Copy link
Collaborator Author

@vkhorikov great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants