From b19a1720442bbe9b594b977877279d5285ddee1a Mon Sep 17 00:00:00 2001 From: Manuel Blum Date: Mon, 3 Mar 2025 13:56:18 +0100 Subject: [PATCH 1/2] fix: eslint should not fail silently. --- .../src/commands/generate/utils/writeGenerated.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts b/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts index e3b284cf3f..69c5d35417 100644 --- a/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts +++ b/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts @@ -15,6 +15,16 @@ export async function writeGenerated(filePath: string, contents: string): Promis filePath, }); + if (lintResult[0].errorCount > 0 || lintResult[0].fatalErrorCount > 0) { + const errorMessage = lintResult[0].messages + .map((message) => { + return message.message; + }) + .join("."); + + console.log(`❌ Linting error in ${filePath}: \n${errorMessage}`); + } + const output = lintResult[0] && lintResult[0].output ? lintResult[0].output : lintResult[0].source; await fs.writeFile(filePath, output ?? contents); console.log(`generated ${filePath}`); From b163a1670b359d4173492c4f4554336396a19779 Mon Sep 17 00:00:00 2001 From: Manuel Blum Date: Mon, 3 Mar 2025 14:17:57 +0100 Subject: [PATCH 2/2] fix: adming-generator - project-service error when formatting not existing file --- .../src/commands/generate/utils/writeGenerated.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts b/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts index 69c5d35417..73ddd545b7 100644 --- a/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts +++ b/packages/admin/admin-generator/src/commands/generate/utils/writeGenerated.ts @@ -11,6 +11,10 @@ export async function writeGenerated(filePath: string, contents: string): Promis cwd: process.cwd(), fix: true, }); + + // Write not linted generated code into file. This is necessary to avoid linting errors like: Parsing error: file/path/file.tsx was not found by the project service. + await fs.writeFile(filePath, contents); + const lintResult = await eslint.lintText(header + contents, { filePath, });