Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support taints/labels on autoscaled node pools #317

Open
NiklasRosenstein opened this issue Feb 3, 2024 · 6 comments
Open

Support taints/labels on autoscaled node pools #317

NiklasRosenstein opened this issue Feb 3, 2024 · 6 comments

Comments

@NiklasRosenstein
Copy link

NiklasRosenstein commented Feb 3, 2024

It looks like the autoscaler implementation for Hetzner cloud now supports taints/labels via HCLOUD_CLUSTER_CONFIG which replaces HCLOUD_CLOUD_INIT and HCLOUD_IMAGE!

See https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/hetzner/README.md

Seems this was added here (kubernetes/autoscaler@e1408ed) and is available in 1.29.0

@kerkmann
Copy link

Would love to see this feature, is there anything where I could help out? ❤️

@vitobotta
Copy link
Owner

Sorry for the delay guys. I finally have a week off work this coming week so I am planning a new release that will include this too.

@vitobotta
Copy link
Owner

@vitobotta
Copy link
Owner

This is now scheduled for 2.0.1. v2.0.0 is going to be released probably next weekend, and 2.0.1 should follow not long after that.

@pashtet04
Copy link

pashtet04 commented Aug 22, 2024

Unable to bootstrap a node pool with autoscaling that includes taints and labels

worker_node_pools:
- name: medium
  instance_type: cpx31
  instance_count: 2
  location: fsn1
- name: medium-autoscaled
  instance_type: cpx31
  instance_count: 2
  location: fsn1
  labels:
    - key: purpose
      value: ci
  taints:
    - key: ci
      value: value:NoSchedule
  autoscaling:
    enabled: true
    min_instances: 0
    max_instances: 3

hetzner-k3s --version
2.0.3

[Node labels] 
Adding labels to medium-autoscaled pool workers...
error: resource(s) were provided, but no name was specified
[Node labels] : error: resource(s) were provided, but no name was specified

@vitobotta
Copy link
Owner

Hi @pashtet04, this change didn't make it into a release yet. I was planning it for 2.0.1 but had to make a couple of releases to fix some more important issues. I will see if I can do it this weekend but I can't promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants