Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark doesn't print a table if terminal doesn't support TTY (in CI for example) #5475

Closed
6 tasks done
sheremet-va opened this issue Apr 2, 2024 · 0 comments · Fixed by #5484
Closed
6 tasks done
Labels
feat: benchmark Issues and PRs related to the benchmark feature p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@sheremet-va
Copy link
Member

sheremet-va commented Apr 2, 2024

Describe the bug

If isTTY in the reporter is not defined or equal to false, then Vitest doesn't print a table with benchmark results like it does when it's true.

Reproduction

https://github.com/vitest-dev/vitest/blob/main/test/benchmark

Run CI=true vitest bench --run --reporter=default

Note that summery there is also not correct:

  visited - test/only.bench.ts > 
    NaNx faster than a0
    NaNx faster than a2
    1.06x faster than visited2

System Info

Any

Used Package Manager

npm

Validations

@sheremet-va sheremet-va added feat: benchmark Issues and PRs related to the benchmark feature p3-minor-bug An edge case that only affects very specific usage (priority) labels Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: benchmark Issues and PRs related to the benchmark feature p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant