fix(require-mock-type-parameters): fixed checking of type annotation (#…

…661)
vitest-dev · Feb 12, 2025 · 20a56a7 · 20a56a7
1 parent 86b3669
commit 20a56a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/rules/require-mock-type-parameters.ts b/src/rules/require-mock-type-parameters.ts
@@ -41,7 +41,7 @@ export default createEslintRule<Options[], MESSAGE_IDS>({
         if (vitestFnCall?.type !== 'vi') return
 
         for (const member of vitestFnCall?.members) {
-          if (!('name' in member) || node.typeArguments !== undefined) continue
+          if (!('name' in member) || member.parent.parent.typeArguments !== undefined) continue
           if (member.name === 'fn') {
             context.report({
               node: member,

diff --git a/tests/require-mock-type-parameters.test.ts b/tests/require-mock-type-parameters.test.ts
@@ -15,6 +15,7 @@ ruleTester.run(RULE_NAME, rule, {
     'vi.fn<MyProcedure>()',
     'vi.fn<any>()',
     'vi.fn<(...args: any[]) => any>(() => {})',
+    'vi.fn<() => string | undefined>().mockReturnValue("some error message");',
     'vi.importActual<{ default: boolean }>("./example.js")',
     'vi.importActual<MyModule>("./example.js")',
     'vi.importActual<any>("./example.js")',