From 4e93d6ba20e935f9a138c6c7e39a9ca1fd0761a0 Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Thu, 2 Dec 2021 15:50:38 +0800 Subject: [PATCH 1/2] chore: deprecate `rollupOptions.output.output` to avoid subtle errors As explained in https://github.com/vitejs/vite/issues/5812#issuecomment-984345618 --- packages/vite/src/node/build.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts index a8eeda6ec97a93..93f25b78e4c40b 100644 --- a/packages/vite/src/node/build.ts +++ b/packages/vite/src/node/build.ts @@ -478,6 +478,15 @@ async function doBuild( try { const buildOutputOptions = (output: OutputOptions = {}): OutputOptions => { + // @ts-ignore + if (output.output) { + config.logger.warn( + `You've set "rollupOptions.output.output" in your config. ` + + `This is deprecated and will override all Vite.js default output options. ` + + `Please use "rollupOptions.output" instead.` + ) + } + return { dir: outDir, format: ssr ? 'cjs' : 'es', From c3743cb0db6d394530ee56bdbacf8581bdd15e2a Mon Sep 17 00:00:00 2001 From: Haoqun Jiang Date: Thu, 2 Dec 2021 16:27:42 +0800 Subject: [PATCH 2/2] chore: format with prettier --- packages/vite/src/node/build.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts index 93f25b78e4c40b..cef74c7ac57f88 100644 --- a/packages/vite/src/node/build.ts +++ b/packages/vite/src/node/build.ts @@ -482,8 +482,8 @@ async function doBuild( if (output.output) { config.logger.warn( `You've set "rollupOptions.output.output" in your config. ` + - `This is deprecated and will override all Vite.js default output options. ` + - `Please use "rollupOptions.output" instead.` + `This is deprecated and will override all Vite.js default output options. ` + + `Please use "rollupOptions.output" instead.` ) }