Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ignore unknown file type in prettier #4738

Merged
merged 1 commit into from
Aug 26, 2021
Merged

chore: ignore unknown file type in prettier #4738

merged 1 commit into from
Aug 26, 2021

Conversation

hannoeru
Copy link
Sponsor Contributor

Description

Allow commit files like example.png

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 26, 2021
Shinigami92
Shinigami92 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know this

@patak-dev patak-dev merged commit 4eafd7e into vitejs:main Aug 26, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@hannoeru @aleclarson
chore: ignore unknown file type in prettier (vitejs#4738)
faa3d01
@jay-Anonymous jay-Anonymous mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannoeru @patak-dev @Shinigami92