Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug): import performance from perf_hooks #13464

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 8, 2023

Description

noticed this from the error logs at #13463. we're accidentally using the global performance object, which only exist in node 16. Causing vite --debug to fail in node 14.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented Jun 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit d458ccd into main Jun 8, 2023
@patak-dev patak-dev deleted the fix-debug-perf-global branch June 8, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants