-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(playground): move to ESM module and add type check for config #12131
refactor(playground): move to ESM module and add type check for config #12131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migrating this! 🙏 I suppose this supersedes #8252. I have a few comments below, and ideally we would also need to add "type": "module"
to the package.json
, but that brings up other minor issues too so it can be tackled later in a separate PR.
db8de68
to
99c4ebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greatly appreciate the refactors!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 💚
Description
// @ts-check
for all config files to be involved intypescheck
of playgrounddefineConfig
whenever possible to get better type intellisenseAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).